qmonnet / rbpf / 11574621665

96%

push

github

src/interpreter.rs: Use wrapping_offset() for load/store operations

Rust 1.83 introduces some additional out-of-bound checks [0], making it
illegal to attempt to load at an out-of-bound access when trying to
load/store values from/to register in rbpf's interpreter, and causing
the program to panick even before we reach the safety checks from
check_mem().

I understand we need to use wrapping_offset() rather than offset() in
that case, which causes the operation itself (but not the resulting
poitner) to be safe, and the checked to be deferred. See also the
related GitHub issue [1].

[0] https://github.com/rust-lang/rust/pull/130251
[1] https://github.com/qmonnet/rbpf/issues/115

Reported-by: Ben Kimock <kimockb@gmail.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>

12 of 12 new or added lines in 1 file covered. (100.0%)

4164 of 4365 relevant lines covered (95.4%)

240.58 hits per line