rust-bitcoin / rust-bitcoin / 11574551330

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3519: psbt: Fix bug in Subtype consensus_encode

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c89b8164377123eb20476636f2f5271c6a687406">c89b81643 psbt: Fix bug in Subtype consensus_encode (Tobin C. Harding)

Pull request description:

  In #2906 we switched from using a `u8` for type keys to using a `u64` and encoding as a compact int (inline with the spec). Note that a `u8` encodes to the same bytes as a `u64` when the value is < 252.

  In that patch, I introduced a bug because the length returned by `PoprietaryKey::consensus_encode` uses a hard code 1 for the length of the encoding (because of single byte) instead of the variable length for the new compact encoding.

  Bug showed up in fuzzing, and was isolated by Jamil - mad props.

  Fix: #3501

ACKs for top commit:
  jamillambert:
    ACK c89b8164377123eb20476636f2f5271c6a687406
  apoelstra:
    ACK c89b8164377123eb20476636f2f5271c6a687406; successfully ran local tests

Tree-SHA512: 1b61b6a9ea6a96c9281714d3575e6b46cfb

2 of 2 new or added lines in 1 file covered. (100.0%)

19761 of 23925 relevant lines covered (82.6%)

18219.65 hits per line