rust-bitcoin / rust-bitcoin / 11560111258

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3045: Remove `bech32` from `address::ParseError`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9a7b1c232b494dccdce091a46d916cc411a612a1">9a7b1c232 Wrap the bech32 decoding error (Tobin C. Harding)

Pull request description:

  In #2381 we attempted to fully encapsulate the `bech32` crate to help with stabalizing `rust-bitcoin` however we failed to notice the `address:ParseError` has a variant that includes `bech32`. Public enums have public variant internals in Rust. Also the `From<bech32::segtiw::DecodeError` makes `bech32` public.

  Closes: #3043

ACKs for top commit:
  apoelstra:
    ACK 9a7b1c232b494dccdce091a46d916cc411a612a1; successfully ran local tests; will one-ACK merge since this is a gazillion years old and obviously right

Tree-SHA512: b5053aa4369a7b67d876d5a2e9c766494ea

2 of 6 new or added lines in 2 files covered. (33.33%)

19750 of 23913 relevant lines covered (82.59%)

18305.83 hits per line