spesmilo / electrum / 5705791355748352

63%

Build Type

push

CirrusCI

Committed by ecdsa

Commit Message

Fix #9280:
 - Wait until HTLCs are irrevocably removed before cleaning up their
   data structures (MPP and forwarding)
 - keep methods maybe_cleanup_mpp and maybe_cleanup_forwarding separate
 - perform cleanup in htlc_switch, so that process_unfulfilled_htlc
   has less side effects
 - In htlc_switch, we blank the onion_packet_hex field to signal that
   an HTLC has been processed. An item of chan.unfulfilled_htlcs may
   go through 4 stages:
   - 1. not forwarded yet: (None, onion_packet_hex)
   - 2. forwarded: (forwarding_key, onion_packet_hex)
   - 3. processed: (forwarding_key, None), not irrevocably removed yet
   - 4. done: (forwarding_key, None), irrevocably removed
 - in test_lnpeer, an extra iteration of htlc_switch has been added to
   trampoline forwarding tests

Run Details

11 of 11 new or added lines in 2 files covered. (100.0%)

3 existing lines in 3 files now uncovered.

19938 of 32795 relevant lines covered (60.8%)

3.03 hits per line