ossuminc / riddl / 11537298164

73%

Build Type

push

Committed by web-flow

Commit Message

Change the name of an option to conform to pattern used by other options. (#679)

The --no-ansi-messages is now accepted for noAnsiMessages field in Common Options

Also:
* Install headers via headerCreate
* Fix the cause of --no-ansi-messages being ignored
* The cause was not using the PlatformContext.withOptions utility in Commands.runMain and other 
   PlatformContext instances asserting themselves in other code.

Other changes getting there:
* Provide a test case for --no-ansi-messages
* Fix the logger to get highlighting setting from PlatformContext not its constructor.
* Remove all duplicate `given`s so confusion doesn't ensue
* Use CommonOptions.default when the logic is default, not empty
* Fix many scaladoc class references
* Convert all use of PlatformContext.setOptions to `withOptions`
  to encapsulate the use of the option setting
* Remove all uses of `PlatformContext.setOptions` and the implementation
* Make a `PlatformContext.withLogger` method for similar reasons and
  use it in placess the logger needs to change (mostly test cases)
* Clean up unused imports
* Make use of AbstractTestingBasis in more places
* Eliminate remaining package objects deferring to utils one
* Eliminate PlatformContext `given`s in test code
* Don't instantiate CommonOptions as much, use static values
* Cleanup PlatformContext
* Remove unused InMemoryLogger, redundant with StringLogger
* Re-enable Test parallel execution
* Clean up imports
* Fix bug in withOptions
* Remove pc.withOptiosn from top level of test suites

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

99 existing lines in 37 files now uncovered.

4829 of 6599 relevant lines covered (73.18%)

0.73 hits per line