rust-bitcoin / rust-bitcoin / 11532797931

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3512: Manually implement `compute_txid` and `compute_wtxid`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5633b10f5c826e0b2ac47dd85f697f12710898d7">5633b10f5 Manually implement compute_txid and compute_wtxid (Tobin C. Harding)

Pull request description:

  We would like to move the `Transaction` type over to `primitives` including the `compute_txid` and `compute_wtxid` functions however currently the implementations, as expected, use `Encodable`.

  Manually implement `Encodable` by hashing all the fields in the correct order.

  Note we have unit tests already that check the output string of the txid returned so these act as regression tests for this patch.

ACKs for top commit:
  apoelstra:
    ACK 5633b10f5c826e0b2ac47dd85f697f12710898d7; successfully ran local tests; nice

Tree-SHA512: 66a955d3d6da7b996b5fcef2687ea8db981

46 of 46 new or added lines in 1 file covered. (100.0%)

19749 of 23909 relevant lines covered (82.6%)

18308.91 hits per line