vpulim / node-soap / 1122

95%

push

travis-ci

Always submit valid XML from the client. (#862)

Previously, if the client made a request that contained ampersands:

    {
      "DummyField1": "foo & bar",
    }

then we would submit invalid XML:

    <n:DummyField1>foo & bar</n:DummyField1>

The WSDL server I'm using (a Service-Now instance) then complains:

    <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
      <SOAP-ENV:Header/>
      <SOAP-ENV:Body>
        <SOAP-ENV:Fault>
          <faultcode>SOAP-ENV:Server</faultcode>
          <faultstring>Unable to parse SOAP document</faultstring>
          <detail>Error completing SOAP request</detail>
        </SOAP-ENV:Fault>
      </SOAP-ENV:Body>
    </SOAP-ENV:Envelope>

We now default to escaping XML, so a stray & can't break usage of node-soap.

3 of 3 new or added lines in 1 file covered. (100.0%)

1743 of 1884 relevant lines covered (92.52%)

7944.75 hits per line