enbility / spine-go / 11484777419
94%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 60
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.712%. Remained the same
11484777419

push

github

web-flow 
Fix: Correct Data Types for Setpoint Description, Selector, and HVAC (#37)

This commit addresses the data type issues in the `Setpoint` and `HVAC`
model messages, specifically for `SetpointDescriptionDataType`,
`SetpointDescriptionListDataSelectorsType`, and
`HvacSystemFunctionSetpointRelationDataType`. It also corrects invalid
types in `function_data_factory.go` for
`FunctionTypeHvacOperationModeDescriptionListData` and
`FunctionTypeHvacSystemFunctionDescriptionListData`.

Changes include:
1. Updating `SetpointId` in `hvacSystemFunctionSetpointRelationListData`
to be a list, as specified in the EEBus SPINE Technical Specification
Resource Specification.
2. Correcting data types for fields in `SetpointDescriptionDataType` and
`SetpointDescriptionListDataSelectorsType` also according to the
Resource Specification.

Before this commit, sending
`FunctionTypeHvacOperationModeDescriptionListData` and
`FunctionTypeHvacSystemFunctionOperationModeRelationListData` failed due
to invalid data types provided to `createFunctionData` in the factory.

Additionally, the `SetpointId` field needed to be a list, not a single
value. According to the specification, an operation mode can have
multiple setpoints (up to four), such as for the "auto" operation mode.

Sending `FunctionTypeSetpointDescriptionListData` also failed due to
incorrect field data types.

With these fixes, requests for
`FunctionTypeSetpointDescriptionListData`,
`FunctionTypeHvacOperationModeDescriptionListData`, and
`FunctionTypeHvacSystemFunctionOperationModeRelationListData` now work
correctly.

## Screen shots from the EEBus SPINE Technical Specification Resource
Specification for quick reference
### 4.3.12.6 hvacSystemFunctionSetpointRelationListData

![image](https://github.com/user-attachments/assets/667d6c72-e4b4-45a1-a4a2-b4d3292f8734)

### 4.3.23.6 setpointDescriptionListData (for
`SetpointDescriptionDataType`)

![image](https://github.com/user-att... (continued)

5022 of 5359 relevant lines covered (93.71%)

88.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11484777419.1 0
93.71
 GitHub Action Run
Source Files on build 11484777419
Detailed source file information is not available for this build.