skeema / skeema / 11484024152

92%

push

github

diff/push: allow safe type conversions to/from vector (MySQL 9)

MySQL 9 added a vector column type, with vector(n) consisting of n 4-byte
floats. When altering a table, vector columns may be converted to other
binary column types safely (and vice versa), as long as the new length cannot
possibly cause truncation. Going from vector(x) to vector(y) is also safe, as
long as x < y.

This commit improves `skeema diff` and `skeema push` to no longer require
the --allow-unsafe option when performing these vector-related column type
modifications.

Additionally, this commit refactors some old code in the same file to no
longer use regular expressions. Older Skeema code (especially circa 2017)
tended to lean on regexp logic in places where Go 1.18's strings.Cut can
handle the task fairly succinctly and more efficiently.

66 of 76 new or added lines in 1 file covered. (86.84%)

10034 of 10760 relevant lines covered (93.25%)

1.12 hits per line