babelfish-for-postgresql / babelfish_extensions / 11475749247

74%

BABEL_5_X_DEV: 77%

push

github

cleanup pltsql state properly in exec_stmt_exec_batch in case of errors (#3036) (#3041)

Some system states like pltsql guc nest level, pltsql scope identity should always be cleaned up at the end of execution even in case of errors since these were defined to be outside of postgres's transaction cleanup control.
So a pltsql_new_guc_nest_level() should always have a pltsql_revert_guc in all cases and vice versa.

This was not happening inside exec_stmt_exec_batch where we could error out even before starting a new pltsql guc nest level and then in catch block we would try to revert a non existent nest level.

As a fix we move out the call to pltsql_new_guc_nest_level() before try block ensuring we have a nest level to revert in catch.

Task: BABEL-5344

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

43049 of 58396 relevant lines covered (73.72%)

142644.35 hits per line