albertito / chasquid / 11420891607

95%

Build Type

push

Committed by albertito

Commit Message

dkim: Make timestamp parsing more robust against overflow

The timestamp string in the t= and x= headers is an "unsigned decimal
integer", but time.Unix takes an int64. Today we parse it as uint64 and
then cast it, but this can cause issues with overflow and type
conversion.

This patch fixes that by parsing the timestamps as signed integers, and
then checking they're positive.

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

5689 of 5999 relevant lines covered (94.83%)

74617.55 hits per line