tarantool / luajit / 11373217521

70%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Restore state when recording __concat metamethod throws an error.

Thanks to Sergey Kaplun.

(cherry picked from commit 7421a1b33)

Since neither `rec_cat()` nor `lj_record_ret()` restore the Lua stack,
if the error is raised, it leads either to a crash in `BC_RET` or to the
"unbalanced stack" assertion failure.

This patch protects the `rec_mm_arith()`, which can raise an error. Its
caller returns the negated error code to be rethrown in case of the
caught error.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#10199

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 420748c99)

Run Details

5673 of 6013 branches covered (94.35%)

Branch coverage included in aggregate %.

15 of 16 new or added lines in 1 file covered. (93.75%)

22 existing lines in 6 files now uncovered.

21595 of 23355 relevant lines covered (92.46%)

878516.86 hits per line