rust-bitcoin / rust-bitcoin / 11369850318

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#3379: bitcoin: Allow deprecated

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5987dd55e79376d8e4044fe495683fb510bb4d65">5987dd55e bitcoin: Allow deprecated (Tobin C. Harding)

Pull request description:

  We are trying to make our upgrade path as painless as possible, as such we are deprecating things and leaving them in for ages. Some things are hard to deprecated (e.g. struct field re-names). A solution is to deprecated in a point release to `0.32.x` so that when users eventually upgrade to use `primitives` they will already have done a bunch of the changes (or preparations).

  As an example, we want to change the transaction field names. If we deprecated them in a `0.32.x` point release and add getter functions then in `primitives` we can use the new names (and eventually deprecate the original getters if we want to).

  To try and keep the diff between `0.32.x` and master as small as possible lets just allow deprecated things on the `0.32.x` branch. This way we can have some chance of getting the linter to pass in CI on backport patches. This also helps with dev so one can run the linter if backporting a patch that requires substantial changes to the original.

ACKs for top commit:
  apoelstra:
    ACK 5987dd55e79376d8e4044fe495683fb510bb4d65 successfully ran local tests

Tree-SHA512: 1d7501a2cef79e8e20f7d251286d247b2bb

18418 of 22144 relevant lines covered (83.17%)

17523.25 hits per line