tarantool / luajit / 11364877142

70%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

FFI: Fix various issues in recff_cdata_arith.

Thanks to Sergey Kaplun.

(cherry picked from commit 7a608e442)

The aforementioned function doesn't handle gentle recording of the cdata
addition to `nil` or some string, presuming that the interpreter will throw
an error. This may lead to an assertion due to an uninitialized ctype
state or an attempt to use in the fold engine the non-cdata summand (casted
to `IR_KPTR`) as the (invalid) GC pointer.

This patch handles such cases by:
* Initializing the ctype state where it is needed.
* Raising an error when the argument has a suspicious type. Since the
  interpreter will throw the error anyway, these traces will abort
  anyway.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#10199

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit a72e884c8)

Run Details

5670 of 6008 branches covered (94.37%)

Branch coverage included in aggregate %.

5 of 6 new or added lines in 1 file covered. (83.33%)

12 existing lines in 2 files now uncovered.

21595 of 23339 relevant lines covered (92.53%)

912331.88 hits per line