rust-bitcoin / rust-bitcoin / 11352313972

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2906: psbt: Encode keytype as a compact size unsigned integer

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2f656f77baf91cc4f3110cc15c7f7e8e20d5d8c1">2f656f77b psbt: Use u64 for key type (Tobin C. Harding)

Pull request description:

  Currently we use `u8` for key type but it was pointed out that we should be using a `u64` and encoding it as a compact type. The reason our code works now is because the compact type encoding for a `u8` (less than

  This breaks the `serde` impl, as shown by changes to the regression tests,

  Fix: #2891

ACKs for top commit:
  apoelstra:
    ACK 2f656f77baf91cc4f3110cc15c7f7e8e20d5d8c1 successfully ran local tests

Tree-SHA512: ce5fe46b53c380f9cd782323893d130cb82

7 of 7 new or added lines in 2 files covered. (100.0%)

19115 of 23178 relevant lines covered (82.47%)

18789.84 hits per line