Qiskit / qiskit / 11299645978

88%

Build Type

push

github

Committed by web-flow

Commit Message

Use PyO3 0.22 and rust-numpy 0.22 (#13313)

* Use PyO3 0.22 and rust-numpy 0.22

This commit migrates to using PyO3 0.22 and rust-numpy and updates all
the deprecated and changed interfaces in the libraries to their new
syntax. No new or alternative interfaces are used as part of this PR
except for where deprecation warnings pointed to do so.

One thing to note is that in pyo3 0.22 a new feature py-clone
was added to re-enable `Py<T>::clone()`. This was disabled by default in
pyo3 0.22 because of a soundness issue around calling that in situations
when the GIL was not held. [1] Right now qiskit relies on using `Clone` on
`Py` objects because we have container types that own a `PyObject` that
we sometimes clone at the top level so this flag needs to be set. In the
future we can look at adding interfaces to avoid needing this flag in
the future.

Another thing to note is that rust-numpy includes support for ndarray
0.16, however this PR doesn't migrate to it because `ndarray_einsum_beta`
used in the `qiskit_accelerate::unitary_compose` module still depends on
ndarray 0.15 and we can't upgrade until that does.

[1] https://pyo3.rs/v0.22.3/migration#pyclone-is-now-gated-behind-the-py-clone-feature

* Fix MSRV

* Disable py-clone on accelerate

Run Details

13 of 16 new or added lines in 10 files covered. (81.25%)

10 existing lines in 2 files now uncovered.

73195 of 82541 relevant lines covered (88.68%)

375070.05 hits per line