• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Qiskit / qiskit / 11299645978
88%

Build:
DEFAULT BRANCH: main
Ran 11 Oct 2024 10:01PM UTC
Jobs 1
Files 891
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Oct 2024 08:57PM UTC coverage: 88.677% (+0.03%) from 88.652%
11299645978

push

github

web-flow
Use PyO3 0.22 and rust-numpy 0.22 (#13313)

* Use PyO3 0.22 and rust-numpy 0.22

This commit migrates to using PyO3 0.22 and rust-numpy and updates all
the deprecated and changed interfaces in the libraries to their new
syntax. No new or alternative interfaces are used as part of this PR
except for where deprecation warnings pointed to do so.

One thing to note is that in pyo3 0.22 a new feature py-clone
was added to re-enable `Py<T>::clone()`. This was disabled by default in
pyo3 0.22 because of a soundness issue around calling that in situations
when the GIL was not held. [1] Right now qiskit relies on using `Clone` on
`Py` objects because we have container types that own a `PyObject` that
we sometimes clone at the top level so this flag needs to be set. In the
future we can look at adding interfaces to avoid needing this flag in
the future.

Another thing to note is that rust-numpy includes support for ndarray
0.16, however this PR doesn't migrate to it because `ndarray_einsum_beta`
used in the `qiskit_accelerate::unitary_compose` module still depends on
ndarray 0.15 and we can't upgrade until that does.

[1] https://pyo3.rs/v0.22.3/migration#pyclone-is-now-gated-behind-the-py-clone-feature

* Fix MSRV

* Disable py-clone on accelerate

13 of 16 new or added lines in 10 files covered. (81.25%)

10 existing lines in 2 files now uncovered.

73195 of 82541 relevant lines covered (88.68%)

375070.05 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
88.99
-2.52% crates/accelerate/src/nlayout.rs

Uncovered Existing Lines

Lines Coverage ∆ File
2
92.98
1.0% crates/qasm2/src/lex.rs
8
79.11
-0.81% crates/accelerate/src/target_transpiler/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 11299645978.1 11 Oct 2024 10:01PM UTC 891
88.68
GitHub Action Run
Source Files on build 11299645978
  • Tree
  • List 891
  • Changed 67
  • Source Changed 22
  • Coverage Changed 24
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #11299645978
  • 1e2d337b on github
  • Prev Build on main (#11277520565)
  • Next Build on main (#11305032303)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc