OpenRefine / OpenRefine / 11287606787

51%

push

github

Option to remove Blank Columns upon project creation (#4757)

* Fix #1750

Three parts of changes:
1. Determine whether a column is blank: (based on https://github.com/OpenRefine/OpenRefine/pull/3497): Create a new list<Boolean> in the TabularImportingParserBase class, that represents whether each column has data. 2. If the store blank column is false, delete this column (only happens when store blank column == false): removeColumn method is created in the ColumnModel class. This will use columns.remove(all empty columns), which will remove both data lines and header lines. 3. The checkbox of the store blank column added to the front-end page. After testing with real files (csv, xls, tsv), this function works. I think it should work on other Tabular files as well, since I'm optimizing directly in the TabularImportingParserBase class. But I'm not really sure how to test in TabularImportingParserBase directly. In addition, I've tested tree files (xml, json), and now it is possible to do blank columns. So I didn't make changes.

* 4757 add some unit tests

* Fix up unit test

* Lint formatter fixups

* Review cleanups

* Add e2e test for blank column import option

* Remove unnecessary try {} block in test

* Remove another unnecessary try {} block in tests

* Remove other unnecessary try {} blocks in tests

---------

Co-authored-by: Tom Morris <tfmorris@gmail.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>

5305 of 12364 branches covered (42.91%)

Branch coverage included in aggregate %.

13358 of 26054 relevant lines covered (51.27%)

2.35 hits per line