shinghim / rust-bitcoin / 11286206195

84%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3296: Remove the `SliceIndex` implementation from hash types

<a class=hub.com/shinghim/rust-bitcoin/commit/3b7ba4f9771b80616925422384d314f148c01b11">3b7ba4f97 Remove the SliceIndex implementation from hash types (Tobin C. Harding)

Pull request description:

  If folk really want to index into a hash they can us `as_byte_array` then index that.

  Includes a bump to the version number of `hashes` to `v0.15.0` - this is because otherwise `secp` won't build since we are breaking an API that is used in the current release of secp.

  Fix: #3115

ACKs for top commit:
  apoelstra:
    ACK 3b7ba4f9771b80616925422384d314f148c01b11 successfully ran local tests

Tree-SHA512: 0ba93268cfa5767d298a33abfce06acca63

Run Details

26 of 26 new or added lines in 15 files covered. (100.0%)

309 existing lines in 8 files now uncovered.

19138 of 23153 relevant lines covered (82.66%)

18800.81 hits per line