fwupd / fwupd / 11282215792
53%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 880
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 49.076% (-0.02%) from 49.091%
11282215792

push

github

superm1 
Simplify firmware loading

Remove the offset from `FuFirmware->tokenize()` and `FuFirmware->parse()` --
out of 128 superclasses only 59 were using it and only 25 were actually using
it *correctly*.

Rather that adding masses of code to fix up the ~80% of plugins doing it wrong,
just remove the feature altogether now that FuPartialStream exists.

We're already creating the FuInputStream with the offset, so just use that in
the superclass with no additional overhead.

19483 of 35491 branches covered (54.9%)

Branch coverage included in aggregate %.

102 of 178 new or added lines in 95 files covered. (57.3%)

30 existing lines in 11 files now uncovered.

58536 of 123485 relevant lines covered (47.4%)

19947.08 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
65.17
 -0.39% libfwupdplugin/fu-efi-device-path.c
1
81.22
 0.0% libfwupdplugin/fu-efi-file.c
1
76.92
 0.0% libfwupdplugin/fu-efi-volume.c
1
80.0
 0.0% libfwupdplugin/fu-smbios.c
1
80.1
 0.0% libfwupdplugin/fu-uswid-firmware.c
1
32.14
 0.0% plugins/acpi-ivrs/fu-acpi-ivrs.c
1
2.6
 0.0% plugins/acpi-phat/fu-acpi-phat-version-element.c
1
3.64
 -0.07% plugins/acpi-phat/fu-acpi-phat-version-record.c
1
2.2
 -0.02% plugins/algoltek-aux/fu-algoltek-aux-firmware.c
1
4.0
 -0.08% plugins/algoltek-usbcr/fu-algoltek-usbcr-firmware.c
1
7.69
 0.0% plugins/amd-kria/fu-amd-kria-image-firmware.c
1
7.69
 0.0% plugins/amd-kria/fu-amd-kria-persistent-firmware.c
1
12.67
 0.0% plugins/ccgx/fu-ccgx-firmware.c
1
6.67
 0.0% plugins/dfu-csr/fu-dfu-csr-firmware.c
1
3.17
 0.0% plugins/ebitdo/fu-ebitdo-firmware.c
1
1.77
 0.0% plugins/elanfp/fu-elanfp-firmware.c
1
40.74
 0.0% plugins/fpc/fu-fpc-ff2-firmware.c
1
1.23
 0.0% plugins/intel-gsc/fu-igsc-aux-firmware.c
1
2.99
 0.0% plugins/intel-gsc/fu-igsc-code-firmware.c
1
1.55
 0.0% plugins/intel-gsc/fu-igsc-oprom-firmware.c
1
2.22
 0.0% plugins/jabra-file/fu-jabra-file-firmware.c
1
1.6
 0.0% plugins/jabra-gnp/fu-jabra-gnp-firmware.c
1
2.82
 0.0% plugins/nordic-hid/fu-nordic-hid-firmware-mcuboot.c
1
2.9
 0.0% plugins/qc-s5gen2/fu-qc-s5gen2-firmware.c
1
2.67
 0.0% plugins/synaptics-cape/fu-synaptics-cape-hid-firmware.c
1
3.08
 0.0% plugins/synaptics-cape/fu-synaptics-cape-sngl-firmware.c
1
2.53
 0.0% plugins/uefi-sbat/fu-uefi-sbat-firmware.c
1
6.49
 0.0% plugins/uf2/fu-uf2-firmware.c
2
85.0
 0.0% libfwupdplugin/fu-hid-report-item.c
2
57.61
 0.0% libfwupdplugin/fu-usb-bos-descriptor.c
2
1.64
 0.0% plugins/acpi-phat/fu-acpi-phat-health-record.c
2
2.86
 0.0% plugins/amd-kria/fu-amd-kria-som-eeprom.c
2
23.08
 0.18% plugins/elantp/fu-elantp-firmware.c
2
0.0
 0.0% plugins/genesys/fu-genesys-usbhub-dev-firmware.c
2
0.0
 0.0% plugins/genesys/fu-genesys-usbhub-pd-firmware.c
2
30.38
 -0.13% plugins/redfish/fu-redfish-smbios.c
2
34.83
 0.0% plugins/synaptics-mst/fu-synaptics-mst-firmware.c
2
36.68
 0.0% plugins/synaptics-rmi/fu-synaptics-rmi-firmware.c
3
0.0
 0.0% plugins/elantp/fu-elantp-haptic-firmware.c
3
0.0
 0.0% plugins/genesys/fu-genesys-usbhub-codesign-firmware.c
4
12.31
 0.0% plugins/acpi-phat/fu-acpi-phat.c
4
1.23
 0.0% plugins/amd-gpu/fu-amd-gpu-atom-firmware.c
4
0.73
 -0.0% plugins/genesys/fu-genesys-usbhub-firmware.c
5
11.76
 -1.0% libfwupdplugin/fu-intel-thunderbolt-firmware.c
5
2.53
 0.03% plugins/uefi-capsule/fu-acpi-uefi.c

Uncovered Existing Lines

Lines Coverage ∆ File
1
65.17
 -0.39% libfwupdplugin/fu-efi-device-path.c
1
85.0
 0.0% libfwupdplugin/fu-hid-report-item.c
1
67.9
 0.0% plugins/ccgx-dmc/fu-ccgx-dmc-firmware.c
1
0.73
 -0.0% plugins/genesys/fu-genesys-usbhub-firmware.c
1
6.49
 0.0% plugins/uf2/fu-uf2-firmware.c
2
87.43
 -0.14% libfwupdplugin/fu-firmware.c
2
0.0
 0.0% plugins/genesys/fu-genesys-usbhub-codesign-firmware.c
3
69.0
 -0.39% libfwupdplugin/fu-context.c
5
88.44
 -1.02% libfwupdplugin/fu-quirks.c
5
78.66
 -0.84% src/fu-history.c
8
79.53
 -4.68% src/fu-daemon.c
Jobs
ID Job ID Ran Files Coverage
1 run-debian-x86_64 - 11282215792.1 880
48.93
 GitHub Action Run
2 run-debian-i386 - 11282215792.2 879
48.99
 GitHub Action Run
Source Files on build 11282215792