rust-bitcoin / rust-bitcoin / 11282275684
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 100
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.662% (+0.009%) from 82.653%
11282275684

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3437: Move `block::Version` to primitives

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/70264bfcece6594a491ea71830a13c2369d09e44">70264bfce<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d5ebb195439c7dc5efe783a7d30a15cfb1b36f88"> Move block::Version to primitives (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/819d8d72e8c6e263c8fa77b30a64bee3d4e9c6e8">819d8d72e</a> Stop using private Version constructor (Tobin C. Harding)

Pull request description:

  This is a straight up move of the whole type because there are only three methods, a getter, a setter, and `is_signalling_soft_fork`.

  If we use an extension trait for `is_signalling_soft_fork` then we have to make the two private associated consts public which is in my opinion worse.

  Patch 1 is preparation, use getter/setter, patch 2 does the move.

ACKs for top commit:
  apoelstra:
    ACK 70264bfcece6594a491ea71830a13c2369d09e44 successfully ran local tests

Tree-SHA512: b61e853b49e540393e4b5404a6a3ef2811f

24 of 27 new or added lines in 2 files covered. (88.89%)

19142 of 23157 relevant lines covered (82.66%)

18907.6 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11282275684.1 0
82.66
 GitHub Action Run
Source Files on build 11282275684
Detailed source file information is not available for this build.