stacklok / minder / 11280802180

53%

push

github

Fix race in github webhook handler tests. (#4721)

* Fix race in github webhook handler tests.

Recent changes introduced a couple additional cases in which we
forward events from the webhook handler to Minder core, causing helper
utility `PassthroughQueue` to get stuck sending on a channel that was
not consumed anymore.

This change should fix the issue by
* consuming the new messages (and running assertions over them)
* ensuring no additional messages are there to be consumed

Additionally, in case tests fail to consume all produced messages, the
test now panics if ran with `-race`.

* Made linter happy.

* Reduced timeout from 1 second to 10 milliseconds.

4 of 4 new or added lines in 1 file covered. (100.0%)

14444 of 27319 relevant lines covered (52.87%)

41.51 hits per line