supabase / auth / 11277025862

69%

push

github

feat: preserve rate limiters in memory across configuration reloads (#1792)

The goal with this change is to preserve the rate limiters across reloads
with the least invasive changes possible. To do this I first added a
LimiterOptions structure to hold the current set of rate limiters. I
then identified each call of tollbooth.New and moved the construction of
the limiter without modifications to options.go. I assigned each limiter
a distinct field to be referenced during the API object creation.

Next I needed to add an optional parameter to the NewAPI methods so I
could store the new LimiterOptions onto the API object for reference
during route construction. To do this without breaking all existing
calls to NewAPI I used the options pattern. This makes the method accept
a parametric set of values implementing a common interface, so future
problems of similar nature can also be added as options.

I then replaced all the local anonymous limiter.Limiters made inline
within the API route construction with each corresponding newly added
field within the LimiterOptions struct.

114 of 120 new or added lines in 4 files covered. (95.0%)

9371 of 16165 relevant lines covered (57.97%)

56.93 hits per line