eclipsesource / jsonforms / 11271007848

83%

push

github

angular: Unsubscribe from state subscriptions on renderer destroy (#2377)

Previously, subscriptions to the JSON Forms state in Angular were never removed when renderer components are destroyed.
With this commit, all subscriptions will be unsubscribed when the component is destroyed.
The base renderer offers an addSubscription method to register one or multiple subscriptions
to automatically be unsubscribed on destroy. With this, extending renderers do not need to
implement the unsubscribe again.

Closes #2354

Co-authored-by: Lucas Koehler <lkoehler@eclipsesource.com>

10155 of 23382 branches covered (43.43%)

16 of 16 new or added lines in 3 files covered. (100.0%)

17261 of 21120 relevant lines covered (81.73%)

27.21 hits per line