keplergl / kepler.gl / 11265264722

62%

Build Type

push

github

Committed by web-flow

Commit Message

[Chore] Remove default props and react-onclickoutside in react functional components (#2679)

Use of defaultProps and findDomNode has been deprecated. This change tries to remove use of both, to avoid React warnings in the dev console.

- Remove defaultProps in functional components, some class components are still using defaultProps
- Add default props to functional components method to be used
- Fix replace-component example
- Remove use of react-clickoutside (which uses findDomNode)

There are still warnings about deprecated APIs from the following dependencies, further dependency upgrade is needed

- react-modal uses findDomNode
- react-markdown uses defaultProps
- react-router: uses childContextTypes

Run Details

4935 of 8127 branches covered (60.72%)

Branch coverage included in aggregate %.

123 of 141 new or added lines in 15 files covered. (87.23%)

1 existing line in 1 file now uncovered.

10341 of 13483 relevant lines covered (76.7%)

97.21 hits per line