2253
88%

Ran 15 Jul 2016 03:30PM UTC

Jobs 5

Files 42

Run time 2min

Badge

Embed ▾

pending completion

Build # 2253

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix flaky test TestResponseClosedBeforeRequest (#438)

On the writer side, the last flush of the "closeRequest" byte would fail
with "mex has been shutdown". The following sequence of events was
causing the issue:

 - Flush calls flushFragment, which sends a frame with the "closeRequest" byte
 - The remote side receives the byte, and closes the response
 - Sender receives the last response frame, and shuts down the mex
 - Original goroutine in Flush calls newFragment (since previous
   fragment) has been sent
 - newFragment fails since the mex has been shutdown

Since this is a valid sequence of events, we ignore the error from
Flush when writing out the closeRequest byte. This issue is unlikely
to happen in production, since the network calls to send and receive
frames should take longer than scheduling the goroutine running Flush.

Run Details

3918 of 4475 relevant lines covered (87.55%)

18763.91 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2253.1 (TEST_TIMEOUT_SCALE=20)	15 Jul 2016 03:31PM UTC	85.83	Travis Job 2253.1
2	2253.2 (TEST_TIMEOUT_SCALE=20)	15 Jul 2016 03:32PM UTC	86.49	Travis Job 2253.2
3	2253.3 (TEST_TIMEOUT_SCALE=20)	15 Jul 2016 03:31PM UTC	86.4	Travis Job 2253.3
4	2253.4 (TEST_TIMEOUT_SCALE=20)	15 Jul 2016 03:30PM UTC	85.8	Travis Job 2253.4
5	2253.5 (TEST_TIMEOUT_SCALE=20)	15 Jul 2016 03:32PM UTC	85.53	Travis Job 2253.5

Source Files on build 2253

Detailed source file information is not available for this build.

uber / tchannel-go / 2253
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2253

uber / tchannel-go / 2253 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2253

uber / tchannel-go / 2253
88%

README BADGES
x