rust-bitcoin / rust-bitcoin / 11257800645

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3443: Input weight prediction helpers for nested P2WPKH

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/aa1fd5f44c9811e1bf2d62f6234ddad54a31ff69">aa1fd5f44<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/78bcca71ca6d55109f0bba2898c0eebad50bc0bd"> Update the doc for InputWeightPrediction::weight() (spacebear)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8fd53c8ecf75918b03d939b40d1683b3bfba97d8">8fd53c8ec</a> Add nested P2WPKH helpers to InputWeightPrediction (spacebear)

Pull request description:

  Following up on https://github.com/rust-bitcoin/rust-bitcoin/issues/630#issuecomment-2392050517.

  I amended the docstring on `InputWeightPrediction::weight()` to clarify that it only returns the signature weight. I'm not sure what the rationale was for only returning partial input weight, and if there are any arguments against something like `InputWeightPrediction::total_weight()` which returns `self.weight() + Weight::from_non_witness_data_size(32 + 4 + 4)` (and maybe deprecate `weight()` eventually to prevent misuse).

ACKs for top commit:
  apoelstra:
    ACK aa1fd5f44c9811e1bf2d62f6234ddad54a31ff69 successfully ran local tests
  tcharding:
    ACK aa1fd5f44c9811e1bf2d62f6234ddad54a31ff69

Tree-SHA512: 9bdd88216c0380d4d56b281029bf30a60ae

9 of 9 new or added lines in 1 file covered. (100.0%)

19104 of 23122 relevant lines covered (82.62%)

18867.61 hits per line