c-ares / c-ares / 11253210594

91%

Build Type

push

github

Committed by web-flow

Commit Message

ares_conn: use sock_funcs.agetsockname() instead of getsockname() (#895)

this change addresses an issue with DNS cookie invalidation for users of
the legacy API and custom network stacks (e.g., Seastar's DNS).

in 02745437, we added an optional `agetsockname` to
`ares_socket_functions_ex` struct, and intended to skip calling this
function in DNS cookie invalidation if this function is not available
for legacy API users.

but we are still calling this system call directly, this fails Seastar's
DNS which uses c-ares to resolve names, and it uses the socket function
table to override the network stack to use its own userspace TCP/IP
stack, in that case, the fd passed to c-ares is not a valid file
descriptor, hence the call fails.

in this change, we

- replace direct getsockname() call with sock_funcs.agetsockname()
- skip the call if agetsockname() is not configured

Refs 02745437

Signed-off-by: Kefu Chai (@tchaikov)

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

22001 of 24125 relevant lines covered (91.2%)

11985.75 hits per line