c-ares / c-ares / 11242518194

91%

Build Type

push

github

Committed by web-flow

Commit Message

Improve socket function replacement subsystem (#894)

Some external users swap out the entire IP stack, such as
[Seastar](https://github.com/scylladb/seastar) that uses DPDK. So we
need to allow them to override all network stack functions used by
c-ares. Since we don't know what network functions may be needed in the
future, we need to make a versioned structure that can be expanded.
We'll need to disable any features in the future if the versioned
interface is less than is required to support any new features.

We recently had a regression when we added DNS Cookie support as we
relied on `getsockname()` to get the local source ip address, but we
were calling the native version since there was no registered callback
available. We will mark this as optional and just skip this step in DNS
Cookie invalidation if its not available for the legacy api users.

Supersedes #893 
Authored-By: Brad House (@bradh352)

Run Details

178 of 216 new or added lines in 10 files covered. (82.41%)

3 existing lines in 1 file now uncovered.

21989 of 24119 relevant lines covered (91.17%)

11909.77 hits per line