stacklok / minder / 11230884732

53%

push

github

Really fix PR origination (#4673)

* Really fix PR origination

There were several bugs in PR origination that were addressed:

* The legacy origination was hardcoded to use GitHub values. This uses
  the per-provider function so we can get the needed info in a general
  way.

* We were using the `RetrieveAllProperties` function to try to persist
  the new entity's properties, while we could have just used the
  `SaveAllProperties` call from the properties service. This actually
  persists as opposed to passing by the more complicated logic.

* We were passing in the incoming properties to persist as opposed to
  the recently retrieved properties. This didn't store the whole view of
  the originated PR, and so we were unable to delete it later on.

Finally, in addition to these changes, we also now don't fail on
deleting and storing legacy entities since newer entities might not need
to do this. Thus, if no legacy entity is created, we instantiate a new
UUID.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Fix unit tests

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

---------

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

25 of 44 new or added lines in 2 files covered. (56.82%)

14644 of 27508 relevant lines covered (53.24%)

41.31 hits per line