stacklok / minder / 11222503525

53%

Build Type

push

github

Committed by web-flow

Commit Message

Use the AddOriginatingEntity/RemoveOriginatingEntity handlers to handle PRs in the webhook provider (#4663)

* Remove DeleteEntityByName

With multiple providers, we might have entities with the same name.
Let's just use DeleteEntity which deletes by ID, forcing the API user to
do a search before.

* Add tests for DeleteOriginatingEntity

We didn't have any tests for this codepath before. Also switches to
making an explicit search through getEntityInner for the PR and then
deleting by ID

* Use the originating webhook handlers for handling PRs in the github webhook handler

Instead of bespoke github-specific code, let's use the new
AddOriginatingEntity and RemoveOriginatingEntity handlers.

Fixes: #4619

* Add a helper properties.NumericalValueToUpstreamID function

* Review feedback

Run Details

39 of 45 new or added lines in 6 files covered. (86.67%)

1 existing line in 1 file now uncovered.

14627 of 27483 relevant lines covered (53.22%)

41.32 hits per line