rust-bitcoin / rust-bitcoin / 11220583898

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2945: Support Testnet4 Network

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2424b654d5bc3e3b509f46b5d261353cdd98ae8b">2424b654d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/31f1a12aaf8208fb341af1ed7409f8385c603a3c"> feat: rust-bitcoin supports testnet4 (BinChengZhao)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/afa91a203048a964cfc820e7bd5fb76ffb088905">afa91a203</a> Introduce TestnetVersion enum with only TestnetV3 (BinChengZhao)

Pull request description:

  Fixed: https://github.com/rust-bitcoin/rust-bitcoin/issues/2749

  1. Adjust `Network` to support `Testnet4`. (Based on https://github.com/rust-bitcoin/rust-bitcoin/issues/2749#issuecomment-2152366608 as an implementation idea.)

  2. Handle conflicting procedure macros and declaration macros, since the original macros can't handle the new `Network::Testnet(TestnetVersion)` structure properly, and make internal implementations compatible with previous versions (e.g., `testnet` for `Testnet3`, `testnet4` for `Testnet4`, to minimize user-side effects).

  3. add `Testnet4` related Params, Block.

  4. optimize compatibility test cases.

  5. Regarding `fn: genesis_block`, calling `bitcoin_genesis_tx` with any Network type internally gets a reasonable `merkle_root`, but not `Testnet4`. (By comparison, I confirmed that the built-in transaction data provided is correct, and combined with the fixed `merkle_root` of `Testnet4` the correct block hash can be computed, which is not possible if the transaction data is incorrect.) **I'd appreciate it if some developer could guide me on what the problem is, and I'll work on it.**

  Of course, all these changes are based on https://github.com/rust-bitcoin/rust-bitcoin/issues/2749 , and the consensus of the discussion, if you have any comments, please leave a message, I will actively improve, and promote the support of `Testnet4`.

ACKs for top commit:
  tcharding:
    ACK 2424b654d5bc3e3b509f46b5d261353cdd98ae8b
  apoelstra:
    ACK 2424b654d5bc3e3b509f46b5d261353cdd98ae8b successfully ran local tests

Tree-SHA512: a501f0a329dfe7c7024265db1483ce9d024

Coverage Stats

130 of 145 new or added lines in 6 files covered. (89.66%)

1 existing line in 1 file now uncovered.

19095 of 23113 relevant lines covered (82.62%)

18923.26 hits per line