tarantool / tarantool / 11219759109

87%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

index_def: make index_def_new non-failing

Function `index_def_new` can fail only due to failure of identifier
validation and due to failure of `key_def_merge` helper. The helper
`key_def_merge` can fail only because of OOM or if multikey validation
has failed.

Firstly, we never need to check identifier in `index_def_new` because we
always do it earlier actually (except for cases we use string literals
for internal indexes, but we don't need to check them anyway), so let's
remove this check. Secondly, `key_def_merge` cannot fail because of
multikey validation in `index_def_new` because the secondary index is
already validated and primary index cannot have multikey path at all.
So here it can fail only because of allocation failure - let's simply
make `key_def_merge` panic on OOM so that `index_def_new` will become
non-failing.

Closes tarantool/security#130

NO_TEST=not reproducible
NO_CHANGELOG=not reproducible
NO_DOC=bugfix

(cherry picked from commit d628b71bc)

Run Details

68443 of 121737 branches covered (56.22%)

1 of 1 new or added line in 1 file covered. (100.0%)

50 existing lines in 22 files now uncovered.

101071 of 115851 relevant lines covered (87.24%)

2546109.9 hits per line