11192041877
63%

Ran 05 Oct 2024 09:13AM UTC

Jobs 10

Files 3

Run time 1min

Badge

Embed ▾

Committed 05 Oct 2024 09:11AM UTC coverage: 73.805%. Remained the same

Build # 11192041877

Build Type

push

github

Committed by

web-flow

Commit Message

grep: avoid shell code evaluation (#749)

* grep: avoid shell code evaluation

* When running grep -g or -u, the default code uses Term::Cap but this fails over to executing external tput command
* tput would be available on Linux/BSD but is not a consideration for Windows
* Feed the TERM environment variable to tput command in single quotes to prevent shell commands from being initiated though TERM
* To verify this I had to temporarily bypass the Term::Cap code on my Linux system
* No other instances of backticks, system() or exec() calls within grep

%TERM='linux;halt -p;' perl  grep -g include a.c   # with patch applied tput fails but system doesn't halt
tput: unknown terminal "linux;halt -p;"
tput: unknown terminal "linux;halt -p;"
#include <stdio.h>
#include <stdlib.h>

* execute tput without subshell

* Previous commit was half baked because invalid user input could still creep into shell
* Switch backticks over to system LIST, which does not execute tput via a shell
* Code for redirecting and restoring STDOUT was lifted out of bin/awk

Run Details

355 of 481 relevant lines covered (73.8%)

47092.15 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	11192041877.1	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
2	11192041877.2	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
3	11192041877.3	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
4	11192041877.4	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
5	11192041877.5	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
6	11192041877.6	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
7	11192041877.7	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
8	11192041877.8	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
9	11192041877.9	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run
10	11192041877.10	05 Oct 2024 09:13AM UTC	73.07	GitHub Action Run

Source Files on build 11192041877

Detailed source file information is not available for this build.

briandfoy / PerlPowerTools / 11192041877
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11192041877

briandfoy / PerlPowerTools / 11192041877 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11192041877

briandfoy / PerlPowerTools / 11192041877
63%

README BADGES
x