Qiskit / qiskit / 11163872363

90%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix bug in QPY symengine payload version handling (backport #13259) (#13260)

* Fix bug in QPY symengine payload version handling (#13259)

This commit fixes a bug that slipped into the sole fix that made up
the now yanked 1.2.3 release, #13251. The fix logic had a typo/mistake
when evaluating the major version in the symengine payload that meant
if you were trying to load a QPY payload generated with a different
symengine release it would always error. This only got through CI because
there was no test coverage of the edge case we were trying to fix. This
commit addresses both issues. It first fixes the typo in the QPY parsing
(which is a 2 character change) and then updates the QPY compat tests to
explicitly test using multiple symengine versions with QPY to make sure
we're exercising this code path moving forward (and validating this
fix).

(cherry picked from commit e5ec41358)

# Conflicts:
#	qiskit/qpy/__init__.py

* Fix merge artifact

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

15 existing lines in 3 files now uncovered.

66889 of 74526 relevant lines covered (89.75%)

218481.9 hits per line