neovim / neovim / 1471

77%

Pull #586

travis-ci

Broken build on 32 bit: Fix -Wtautological-constant-out-of-range-compare.

Problem:

[ 51%] Building C object src/CMakeFiles/nvim.dir/os/rstream.c.o
/Users/eliseo/projects/os/neovim/src/os/rstream.c:237:24: error: comparison of constant
      9223372036854775807 with expression of type 'size_t' (aka 'unsigned long') is always true
      [-Werror,-Wtautological-constant-out-of-range-compare]
  assert(rstream->fpos <= INT64_MAX);
         ~~~~~~~~~~~~~ ^  ~~~~~~~~~
/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^

Solution:

Upcast rstream->fpos to (uintmax_t) to avoid warning in this particular
case (libuv strangely not using usual types for sizes/offsets).
By @aktau (Nicolas Hillegeer).

3 of 3 new or added lines in 3 files covered. (100.0%)

64955 of 113380 relevant lines covered (57.29%)

90581.78 hits per line