Ran
|
Jobs
1
|
Files
855
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
github
Fix bug in QPY symengine payload version handling (#13259) This commit fixes a bug that slipped into the sole fix that made up the now yanked 1.2.3 release, #13251. The fix logic had a typo/mistake when evaluating the major version in the symengine payload that meant if you were trying to load a QPY payload generated with a different symengine release it would always error. This only got through CI because there was no test coverage of the edge case we were trying to fix. This commit addresses both issues. It first fixes the typo in the QPY parsing (which is a 2 character change) and then updates the QPY compat tests to explicitly test using multiple symengine versions with QPY to make sure we're exercising this code path moving forward (and validating this fix). (cherry picked from commit e5ec41358) # Conflicts: # qiskit/qpy/__init__.py
0 of 1 new or added line in 1 file covered. (0.0%)
21 existing lines in 2 files now uncovered.66880 of 74526 relevant lines covered (89.74%)
219274.15 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
80.81 |
0.0% | qiskit/qpy/common.py |
Lines | Coverage | ∆ | File |
---|---|---|---|
3 |
92.48 |
0.5% | crates/qasm2/src/lex.rs |
18 |
96.69 |
-0.92% | crates/qasm2/src/parse.rs |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 11152805998.1 | 855 |
89.74 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|