pybricks / pybricks-micropython / 11145354401

50%

master: 50%

Build Type

push

github

Committed by laurensvalk

Commit Message

pbio/sys/hmi: Run hmi only while user program inactive.

The previous approach would go to the start but still run until the next yield. This meant that if the stop button was pressed while a program gracefully exists, it would already be in the "second stage" of the following

        PT_WAIT_UNTIL(pt, !button_pressed);
        PT_WAIT_UNTIL(pt, button_pressed);
        PT_WAIT_UNTIL(pt, !button_pressed);
        pbsys_main_program_request_start(selected_slot);

Then on release, the program would immediately restart.

PT_EXIT has the same effect of resetting the state to the start, but existing immediately after that.

Fixes https://github.com/pybricks/support/issues/1863

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

3862 of 6797 relevant lines covered (56.82%)

20467109.34 hits per line