kubernetes-sigs / kubebuilder / 11128859987
61%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 44
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.116%. Remained the same
11128859987

push

github

web-flow 
:warning:  (go/v4) decouple webhooks from APIs (Move Webhooks from `api/<version>` or `api/<group>/<version>` to `internal/webhook/<version>` or `internal/webhook/<group>/<version>`) (#4150)

:warning: (go/v4) decouple webhooks from APIs - Move Webhooks from `api/<version>` or `api/<group>/<version>` to `internal/webhook/<version>` or `internal/webhook/<group>/<version>`

This PR decouples the webhooks from the API, aligning with the recent breaking changes introduced in controller-runtime to ensure that kubebuilder still compatbile with its next release.  Webhooks are now scaffolded under `internal/webhook` to comply with the latest standards.

**Context:**

Controller-runtime deprecated and removed the webhook methods in favor of CustomInterfaces (see [controller-runtime#2641](https://github.com/kubernetes-sigs/controller-runtime/issues/2641)). The motivation for this change is outlined in [controller-runtime#2596](https://github.com/kubernetes-sigs/controller-runtime/issues/2596).

See that the current master branch already reflects these changes, using the CustomInterfaces: [kubebuilder#4060](https://github.com/kubernetes-sigs/kubebuilder/pull/4060).

**Changes:**

- Webhooks are now scaffolded in `internal/webhook/<version>` or `internal/webhook/<group>/<version>`.
- However, to ensure backwards compatibility, a new `--legacy` flag is introduced. Running `kubebuilder create webhook [options] --legacy` will scaffold webhooks in the legacy location for projects that need to retain the old structure. However, users will still to address the breaking changes in the source code by replacing the old methods by the new CustomInterfaces.

2282 of 2779 relevant lines covered (82.12%)

15.79 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11128859987.1 44
82.12
 GitHub Action Run
Source Files on build 11128859987