rust-bitcoin / rust-bitcoin / 11127648557

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3410: Fix buggy cfg in rustdocs

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8bb0d3f6674b22f0dbb68b2ea2c079e1379700b7">8bb0d3f66<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/de120de5b9f3495b8c1a157fe291f9b93438d789"> Fix buggy cfg in rustdocs (Tobin C. Harding)

Pull request description:

  In <a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b9643bf3e9b21e4e2207ea210d1d57ffa014d271">b9643bf3e</a> we introduced an incorrect `cfg` attribute, that has just shown up, no clue why clippy only just presented me with this error now. Anywho, the current code is buggy and the rustdoc tests are never being run.

  Fix `cfg` attribute to use the feature name correctly and fix the imports so the code runs.

  Maintain the explicit `main` so that we can return an error using the `?` operator. Remove the empty `main` because its not needed anymore, it is a hang-over from Rust back in the day (before main was automatically added, IIUC).

ACKs for top commit:
  apoelstra:
    ACK 8bb0d3f6674b22f0dbb68b2ea2c079e1379700b7 successfully ran local tests

Tree-SHA512: 27f571ac3efa4bcfc0c80d41957533b9efe

19022 of 23035 relevant lines covered (82.58%)

19089.03 hits per line