• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

safe-global / safe-smart-account / 11127067169
94%
main: 94%

Build:
Build:
LAST BUILD BRANCH: patch-2
DEFAULT BRANCH: main
Ran 01 Oct 2024 02:07PM UTC
Jobs 1
Files 32
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Oct 2024 02:06PM UTC coverage: 93.871% (-0.3%) from 94.196%
11127067169

push

github

web-flow
Feature(v1.4.1): Zksync compatibility (#840)

This PR "backmerges" the zksync compatibility from `main` to the `1.4.1`
release branch.

Backmerge is quoted because it turned out to be much more complicated
and led to more significant changes, such as:
- 1.4.1 was still using ethers v5, zksync plugins require ethers v6, so
I had to migrate the ethers version used in the project (I didn't
migrate it per se; I just used the `test` and `src` folders from the
`main` branch, minus the 1.5.0 changes)
- I migrated the project from `yarn` to `npm` because when I
cherry-picked from main, which uses npm, it was easier to do so rather
than sticking to `yarn`
- backmerging also led to discovering certain issues that were fixed in
`main`, such as broken benchmark on the CI when the compiler version
`0.8.2` is used and node version v16 being unsupported by hardhat
anymore

**TL:DR**
This PR is a 1.4.1 release with 1.5.0 tests, javascript utilities and
hardhat env, minus changes introduced in 1.5.0.

**How I tested the PR**:
- I made sure no changes were made to the contracts and checking that
they're still deployed to expected v1.4.1 addresses
- I ran zkSync test suite and deployed the contracts to zksync sepolia.
Proof of deployment:
```
> @safe-global/safe-smart-account@1.4.1-build.0 deploy-all
> hardhat deploy-contracts --network zkSyncSepolia

Yul codegen is only supported for solc >= 0.8. Flag forceEVMLA will automatically be set to true by default.
Yul codegen is only supported for solc >= 0.8. Flag forceEVMLA will automatically be set to true by default.
Nothing to compile
No need to generate any newer typings.
reusing "SimulateTxAccessor" at 0xdd35026932273768A3e31F4efF7313B5B7A7199d
reusing "SafeProxyFactory" at 0xc329D02fd8CB2fc13aa919005aF46320794a8629
reusing "TokenCallbackHandler" at 0xd508168Db968De1EBc6f288322e6C820137eeF79
reusing "CompatibilityFallbackHandler" at 0x9301E98DD367135f21bdF66f342A249c9D5F9069
reusin... (continued)

241 of 268 branches covered (89.93%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

387 of 401 relevant lines covered (96.51%)

88.51 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-$ - 11127067169.1 01 Oct 2024 02:07PM UTC 0
93.87
GitHub Action Run
Source Files on build 11127067169
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #11127067169
  • 04400467 on github
  • Prev Build on release/v1.4.1 (#10809674669)
  • Next Build on release/v1.4.1 (#11145744176)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc