rust-bitcoin / rust-bitcoin / 11110281725

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3421: Const locktime constructors

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/de319670ae2b0ec1554f5265cdc5978f0d9adcdd">de319670a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/95be55177e1be7919af10355d02efb8aab9ca617"> feat: Create relative lock times at compile time (Christian Lewe)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/53e1fb6b0cc32f8d49d509c91b8426f4797dee0f">53e1fb6b0</a> feat: Create absolute lock time at compile time (Christian Lewe)

Pull request description:

  I noticed that I cannot create lock times as compile-time constants. This PR tries to remedy this issue by marking lock time constructors as `const`.

  Because the `internals` crate depends on the `units` crate in a way that I don't fully understand yet, this PR updates the `units` crate only.

  If `from_consensus` is being kept non-`const` by design, to keep the API flexible to future changes, then please close this PR. In this case, I overlooked existing discussions.

ACKs for top commit:
  apoelstra:
    ACK de319670ae2b0ec1554f5265cdc5978f0d9adcdd successfully ran local tests; good start; should backport
  tcharding:
    ACK de319670ae2b0ec1554f5265cdc5978f0d9adcdd

Tree-SHA512: 69f914770ee46918e3914ead51d50b13152

14 of 16 new or added lines in 2 files covered. (87.5%)

18998 of 23020 relevant lines covered (82.53%)

18146.24 hits per line