curationexperts / laevigata / bab3eb58-d8d0-42d5-bf04-0110357b8d09
97%

DEFAULT BRANCH: main
Ran
Jobs 4
Files 139
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.139% (-0.002%) from 97.141%
bab3eb58-d8d0-42d5-bf04-0110357b8d09

push

circleci

mark-dce 
[REFACTOR] Use rails convenience methods instead of discrete logic

**RATIONALE**
Many of the methods in the LaevigataNotification class use discrete
logic that duplicates the behavior of ruby convenience methods.

The convenience methods are shorter and seem clearer, so I'm using them
instead.

7 of 8 new or added lines in 1 file covered. (87.5%)

343 existing lines in 42 files now uncovered.

2818 of 2901 relevant lines covered (97.14%)

52.25 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
92.86
 -3.81% app/services/hyrax/workflow/laevigata_notification.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
80.0
 -20.0% app/helpers/application_helper.rb
1
98.04
 -1.96% app/forms/hyrax/etd_form.rb
1
96.15
 -3.85% app/forms/single_valued_form.rb
1
87.5
 -12.5% app/presenters/etd_file_set_presenter.rb
1
75.0
 -12.5% app/controllers/concerns/http_auth_concern.rb
1
94.74
 -2.63% app/controllers/in_progress_etds_controller.rb
1
85.71
 -14.29% app/models/registrar_feed.rb
1
90.0
 -10.0% app/controllers/schools_controller.rb
1
99.21
 -0.79% app/services/graduation_service.rb
2
98.55
 -1.45% lib/workflow_setup.rb
2
66.67
 -22.22% app/services/hyrax/workflow/comment_notification.rb
2
66.67
 -22.22% app/services/hyrax/workflow/pending_review_notification.rb
2
80.0
 -20.0% app/validators/about_me_validator.rb
2
93.94
 -6.06% app/models/file_set.rb
2
80.0
 -20.0% app/validators/my_etd_validator.rb
2
66.67
 -22.22% app/services/hyrax/workflow/reviewed_notification.rb
2
87.5
 -12.5% app/actors/hyrax/actors/pregrad_embargo.rb
2
80.0
 -20.0% app/validators/keyword_validator.rb
2
81.82
 -9.09% app/models/committee_member.rb
2
89.74
 -5.13% app/models/ability.rb
2
92.59
 -7.41% app/services/hyrax/statistics/depositors/summary.rb
3
40.0
 -60.0% app/constraints/user_is_admin.rb
3
88.46
 -11.54% app/services/hyrax/laevigata_authority_service.rb
3
66.67
 -33.33% app/services/hyrax/workflow/changes_required_notification.rb
3
72.73
 -27.27% app/validators/my_advisor_validator.rb
4
66.67
 -33.33% app/validators/my_program_validator.rb
4
87.5
 -12.5% app/actors/hyrax/actors/default_admin_set_actor.rb
5
81.48
 -18.52% app/models/schools/school.rb
6
71.43
 -28.57% app/presenters/git_sha_presenter.rb
6
57.14
 -42.86% app/jobs/registrar_job.rb
7
77.78
 -15.56% app/jobs/attach_files_to_work_job.rb
7
95.39
 -4.61% app/models/etd.rb
7
88.89
 -11.11% app/services/visibility_translator.rb
8
52.94
 -47.06% app/validators/my_files_validator.rb
10
23.08
 -76.92% app/helpers/graduation_helper.rb
11
50.0
 -50.0% config/initializers/okcomputer.rb
14
78.95
 -14.74% app/presenters/etd_presenter.rb
19
79.79
 -20.21% app/models/in_progress_etd.rb
24
62.86
 -34.29% app/jobs/graduation_job.rb
24
40.74
 -44.44% app/actors/hyrax/actors/create_with_remote_files_actor.rb
29
66.28
 -33.72% app/controllers/hyrax/etds_controller.rb
113
20.0
 -70.63% app/models/proquest_behaviors.rb
Jobs
ID Job ID Ran Files Coverage
1 bab3eb58-d8d0-42d5-bf04-0110357b8d09.1 122
82.89
2 bab3eb58-d8d0-42d5-bf04-0110357b8d09.2 120
79.66
3 bab3eb58-d8d0-42d5-bf04-0110357b8d09.3 120
90.17
4 bab3eb58-d8d0-42d5-bf04-0110357b8d09.4 115
88.01
Source Files on build bab3eb58-d8d0-42d5-bf04-0110357b8d09