rust-bitcoin / rust-bitcoin / 11053372826
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 99
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.85% (+0.02%) from 82.831%
11053372826

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3411: script: refactor push_int_unchecked and test push_int overflow

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a33bcd3654640ec7aa1cbf13fc9cd8b1be0d757d">a33bcd365<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/be4dffbb5b16ba913bd6bd110402c5545ebf1c0e"> test: ensure push_int check i32::MIN of overflow error (Chris Hyunhum Cho)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/rust-bitcoin/rust-bitcoin/commit/c9988ba8cb352d4a4c37d23083345e05de665a89">c9988ba8c</a> refactor: use match for OP_N push in push_int_unchecked (Chris Hyunhum Cho)

Pull request description:

  Follow up https://github.com/rust-bitcoin/rust-bitcoin/pull/3392

  c9988ba8cb352d4a4c37d23083345e05de665a89
  - refactor `push_int_unchecked` with match expression for cleaner code(many thanks for tcharding https://github.com/rust-bitcoin/rust-bitcoin/issues/3407).

  a33bcd3654640ec7aa1cbf13fc9cd8b1be0d757d
  - ensure newly introduced safe `push_int` function as expected, testing if returns `Error::NumericOverflow` when `n` is `i32::MIN`

ACKs for top commit:
  tcharding:
    ACK a33bcd3654640ec7aa1cbf13fc9cd8b1be0d757d
  apoelstra:
    ACK a33bcd3654640ec7aa1cbf13fc9cd8b1be0d757d successfully ran local tests

Tree-SHA512: 14f19d37f86be0c06147302249016e3cd54

9 of 9 new or added lines in 2 files covered. (100.0%)

19005 of 22939 relevant lines covered (82.85%)

18305.9 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11053372826.1 0
82.85
 GitHub Action Run
Source Files on build 11053372826
Detailed source file information is not available for this build.