tarantool
/
tarantool
/
11029364698
87%
master: 87%
master: 87%
|
Ran
|
Jobs
1
|
Files
514
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.246% (+0.008%) from 87.238%
push
github
lockervinyl: fix crash when empty PK DDL races with DML Vinyl doesn't support altering the primary index of a non-empty space, but the check forbidding this isn't entirely reliable - the DDL function may yield to wait for pending WAL writes to finish after ensuring that the space doesn't contain any tuples. If a new tuples is inserted into the space in the meantime, the DDL operation will proceed rebuilding the primary index and trigger a crash because the code is written on the assumption that it's rebuilding a secondary index: ``` ./src/box/vinyl.c:1572: vy_check_is_unique_secondary_one: Assertion `lsm->index_id > 0' failed. ``` Let's fix this by moving the check after syncing on WAL. Closes #10603 NO_DOC=bug fix (cherry picked from commit 955537b57)
68452 of 121721 branches covered (56.24%)
3 of 3 new or added lines in 1 file covered. (100.0%)
30 existing lines in 15 files now uncovered.101059 of 115832 relevant lines covered (87.25%)
2485488.53 hits per line
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
92.93 |
-0.1% | src/lib/core/fiber.c |
| 1 |
22.6 |
-0.02% | src/lib/uri/uri_parser.c |
| 1 |
91.27 |
0.0% | src/box/box.cc |
| 1 |
92.12 |
0.0% | src/box/vinyl.c |
| 1 |
84.26 |
0.02% | src/box/xlog.c |
| 1 |
96.28 |
-0.53% | src/box/vy_range.c |
| 1 |
91.45 |
-0.11% | src/lib/swim/swim.c |
| 2 |
87.6 |
-0.14% | src/box/vy_run.c |
| 2 |
95.05 |
-0.62% | src/box/raft.c |
| 2 |
95.4 |
-0.19% | src/box/tuple_compare.cc |
| 2 |
95.45 |
-4.55% | src/lib/json/json.h |
| 2 |
94.11 |
-0.39% | src/lua/fiber.c |
| 3 |
94.55 |
-0.22% | src/box/xrow_update_field.c |
| 3 |
89.61 |
-0.54% | src/box/wal.c |
| 7 |
94.55 |
-1.53% | src/box/vy_read_iterator.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 11029364698.1 | 514 |
87.25 |
GitHub Action Run |
