bitcoindevkit / rust-esplora-client / 11025243440

88%

push

github

Merge bitcoindevkit/rust-esplora-client#93: refactor(async): refactoring async client and minor documentation improvements

110393647 chore(style+docs): style and docs retouch (Leonardo Lima)
442789cca chore(style): update new methods style (Leonardo Lima)
565d79e4a refactor(async): add common GET and POST methods (Leonardo Lima)
31dfa4b9f chore(docs): minor improvements on docstrings (Leonardo Lima)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  It builds on top of #95. Applies minor improvements on some docstrings, and Cargo.toml standard.

  The main change is adding the common HTTP methods for the `AsyncClient`, it removes duplicated code from each Esplora API request, and follows the approach done for `BlockingClient`.

  It makes it easier to extract these methods into an `AsyncEsploraClient` trait (to be done in another PR, initially done here 9cbc3873c), which the user can implement with any HTTP client of its choice. Also, makes it simpler to rebase and update the `AsyncAnonymizedClient` from #67.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  It has some commits from #95, as it builds on top of it and should be merged afterward. Please let me know what you think about the proposed changes and approach.

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  - Applies minor improvements on documentation.
  - Add common `get_response` and `post_request` methods to `AsyncClient`, previously duplicated through the esplora API calls. It follows the approach done for `BlockinClient`.

  <!-- Notice the release manager should ... (continued)

105 of 120 new or added lines in 1 file covered. (87.5%)

1019 of 1142 relevant lines covered (89.23%)

9.22 hits per line