• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

supabase / auth / 11017821166
69%

Build:
DEFAULT BRANCH: master
Ran 24 Sep 2024 04:23PM UTC
Jobs 1
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Sep 2024 04:17PM UTC coverage: 57.79% (+0.05%) from 57.743%
11017821166

push

github

web-flow
fix: magiclink failing due to passwordStrength check (#1769)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

https://github.com/supabase/auth/issues/1761

## What is the new behavior?

Now the password should generate secure enough with the necessary
password requirements specified in environment variables.

## Additional context

Basically this line in /internal/api/magic_link.go
password.Generate(64, 10, 1, false, true)
Generates an invalid value for this line in /internal/api/signup.go
if err := a.checkPasswordStrength(ctx, p.Password); err != nil {

---------

Co-authored-by: Chris Stockton <180184+cstockton@users.noreply.github.com>

30 of 38 new or added lines in 3 files covered. (78.95%)

9243 of 15994 relevant lines covered (57.79%)

56.34 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
64.12
0.12% internal/crypto/crypto.go
6
79.14
0.35% internal/crypto/password.go
Jobs
ID Job ID Ran Files Coverage
1 11017821166.1 24 Sep 2024 04:23PM UTC 128
57.79
GitHub Action Run
Source Files on build 11017821166
  • Tree
  • List 128
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 7a5411f1 on github
  • Prev Build on master (#11009059564)
  • Next Build on master (#11048263084)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc