• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

evolution-gaming / kafka-journal / 11017763458
94%

Build:
DEFAULT BRANCH: master
Ran 24 Sep 2024 04:20PM UTC
Jobs 1
Files 198
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Sep 2024 04:14PM UTC coverage: 80.808% (-0.1%) from 80.954%
11017763458

push

web-flow
Add meta_record_id into journal & record_id metajournal tables for gaining correlation between them (#665)

### Problem
KJ can be in inconsistent state when (after purging) meta from
`metajournal` was deleted while events from `journal` left behind. By
itself its not an issue, but after the journal used again and new meta
inserted - then old events will be available (probably with duplicated
`seqNr`).

### Solution 
Create correlation between meta and events that belong to it, i. e. were
created while the meta was present. Then, on reading journal, only
events that correlate with meta must be used.

### Implementation 
Add `meta_record_id` column to `journal` and `record_id` column to
`metajournal` tables. In appending events `RecordId` from meta will be
used (if meta has it) and if meta is not present yet - new `RecordId`
generated. On reading compare `RecordId` from meta and event ignoring
events with another value. `RecordId` is optional value thus validation
takes place only if its present in meta.

Co-authored-by: Denys Fakhritdinov <dfakhritdinov@evolution.com>

49 of 56 new or added lines in 7 files covered. (87.5%)

14 existing lines in 12 files now uncovered.

3280 of 4059 relevant lines covered (80.81%)

1.35 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
88.89
eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/RecordId.scala
1
90.19
-0.29% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/ReplicatedCassandra.scala
5
87.14
-3.77% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/EventualCassandra.scala

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.08
-1.92% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/JournalStatements.scala
1
95.45
-4.55% persistence/src/main/scala/akka/persistence/kafka/journal/ToKey.scala
1
75.86
-3.45% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/SegmentSize.scala
1
92.86
-3.57% journal/src/main/scala/com/evolutiongaming/kafka/journal/HeadCacheConsumption.scala
1
80.0
-1.11% replicator/src/main/scala/com/evolutiongaming/kafka/journal/replicator/DistributeJob.scala
1
90.0
0.0% journal/src/main/scala/com/evolutiongaming/kafka/journal/Events.scala
1
77.97
-1.69% replicator/src/main/scala/com/evolutiongaming/kafka/journal/replicator/ReplicateRecords.scala
1
86.49
-2.7% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/SegmentNr.scala
1
96.25
-1.25% replicator/src/main/scala/com/evolutiongaming/kafka/journal/replicator/TopicReplicator.scala
1
50.0
-50.0% core/src/main/scala/com/evolutiongaming/kafka/journal/FromConfigReaderResult.scala
1
83.33
0.0% snapshot/src/main/scala/com/evolutiongaming/kafka/journal/BufferNr.scala
3
85.37
-3.66% journal/src/main/scala/com/evolutiongaming/kafka/journal/HeadCache.scala
Jobs
ID Job ID Ran Files Coverage
1 Scala 2.13.14 - 11017763458.1 24 Sep 2024 04:20PM UTC 198
80.81
Source Files on build 11017763458
  • Tree
  • List 198
  • Changed 49
  • Source Changed 7
  • Coverage Changed 24
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 0be7edd7 on github
  • Prev Build on master (#10900866320)
  • Next Build on master (#11018088362)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc