rust-bitcoin / rust-bitcoin / 11001636260

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3298: hashes: Rename length field and use u64

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cbfddb03942a110ad6f1044f039164a97c36896c">cbfddb039 hashes: Rename length field and use u64 (Tobin C. Harding)

Pull request description:

  The hash engine types have a `length` field that is used to cache the number of bytes hashed so far, as such it is an arbitrary number and could use a `u64` instead of `usize`.

  While we are at it rename `length` to `bytes_hashed` to remove any ambiguity of what this field is. Note this field is private, we already have the public getter `n_bytes_hashes` to get the value.

  Introduce a private function `incomplete_block_size`, the purpose of this function is to put all the casts in one place so they can be well documented and easily understood.

  Fix: #3016

ACKs for top commit:
  apoelstra:
    ACK cbfddb03942a110ad6f1044f039164a97c36896c successfully ran local tests

Tree-SHA512: a9d93293899066270070c2c4978ec8fd934

59 of 70 new or added lines in 12 files covered. (84.29%)

18943 of 22905 relevant lines covered (82.7%)

18261.33 hits per line