curationexperts / laevigata / a78c635f-c03c-4ce9-b542-8ee93bfb6545
97%

DEFAULT BRANCH: main
Ran
Jobs 4
Files 139
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.449% (+0.2%) from 96.254%
a78c635f-c03c-4ce9-b542-8ee93bfb6545

push

circleci

mark-dce 
[MAINTENANCE] Remove legacy data format support

**ISSUE**
At one point, the data model stored embargo flags in multiple
formats. The data has since been normalized and all ETDs are
populated with a TRUE/FALSE boolean value for each embargo flag.

An analysis of the current Solr index confirms this:
* has_model_ssim:Etd - 12,652
* abstract_embargoed_bsi:* - 12,652
* files_embargoed_bsi:* - 12,652
* toc_embargoed_bsi:* - 12,652

Further, the *_tesim values have been removed from the index (see
supporting data below)

Therefore, we no longer require the datatype fallbacks impelmented
to support the non-normalized data.

**RESOLUTION**
Simplify the SolrDocument model by removing obsolete data type spport.

**BOOLEANS**
```
/ 20240923112632
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_bsi%3A*&facet.query=files_embargoed_bsi%3A*&facet.query=toc_embargoed_bsi%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 24,
    "params": {
      "facet.query": [
        "abstract_embargoed_bsi:*",
        "files_embargoed_bsi:*",
        "toc_embargoed_bsi:*"
      ],
      "q": "has_model_ssim:Etd",
      "indent": "true",
      "q.op": "OR",
      "rows": "0",
      "facet": "true"
    }
  },
  "response": {
    "numFound": 12652,
    "start": 0,
    "maxScore": 2.7608676,
    "numFoundExact": true,
    "docs": [

    ]
  },
  "facet_counts": {
    "facet_queries": {
      "abstract_embargoed_bsi:*": 12652,
      "files_embargoed_bsi:*": 12652,
      "toc_embargoed_bsi:*": 12652
    }
  }
}
```

**_TESIM**
```
// 20240923113202
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_tesim%3A*&facet.query=files_embargoed_tesim%3A*&facet.query=toc_embargoed_tesim%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 3,
    "params": {
      "facet.query": [
        "abstract_embarg... (continued)

3 of 3 new or added lines in 1 file covered. (100.0%)

235 existing lines in 32 files now uncovered.

2852 of 2957 relevant lines covered (96.45%)

53.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
71.43
 -14.29% app/services/research_field_service.rb
1
86.36
 4.55% app/models/committee_member.rb
1
97.37
 3.29% app/models/etd.rb
1
90.0
 -10.0% app/controllers/schools_controller.rb
2
98.55
 -1.45% lib/workflow_setup.rb
2
80.0
 -20.0% app/validators/about_me_validator.rb
2
87.88
 -6.06% app/models/file_set.rb
2
80.0
 -20.0% app/validators/my_etd_validator.rb
2
66.67
 -22.22% app/services/hyrax/workflow/unhidden_notification.rb
2
63.64
 -18.18% app/services/hyrax/workflow/hidden_notification.rb
2
80.0
 -20.0% app/validators/keyword_validator.rb
2
92.59
 -3.7% app/services/hyrax/statistics/depositors/summary.rb
3
66.67
 -33.33% app/services/hyrax/workflow/changes_required_notification.rb
3
52.94
 -17.65% app/validators/my_files_validator.rb
3
72.73
 -27.27% app/validators/my_advisor_validator.rb
4
66.67
 -33.33% app/validators/my_program_validator.rb
4
51.72
 -10.34% app/models/schools/department.rb
4
87.5
 6.25% app/actors/hyrax/actors/default_admin_set_actor.rb
5
69.23
 -3.85% app/services/hyrax/laevigata_authority_service.rb
6
71.43
 -28.57% app/presenters/git_sha_presenter.rb
6
62.5
 -37.5% app/actors/hyrax/actors/pregrad_embargo.rb
8
69.23
 -30.77% app/forms/single_valued_form.rb
8
23.08
 -61.54% app/helpers/graduation_helper.rb
10
35.0
 -50.0% app/jobs/proquest_job.rb
10
76.6
 -9.57% app/models/in_progress_etd.rb
11
50.0
 -50.0% config/initializers/okcomputer.rb
12
55.56
 -44.44% app/models/schools/school.rb
13
59.3
 8.14% app/controllers/hyrax/etds_controller.rb
15
47.37
 -39.47% app/controllers/in_progress_etds_controller.rb
18
74.75
 -18.18% app/forms/hyrax/etd_form.rb
22
65.71
 -28.57% app/jobs/graduation_job.rb
50
60.63
 -38.58% app/services/graduation_service.rb
Jobs
ID Job ID Ran Files Coverage
1 a78c635f-c03c-4ce9-b542-8ee93bfb6545.1 124
84.43
2 a78c635f-c03c-4ce9-b542-8ee93bfb6545.2 119
79.22
3 a78c635f-c03c-4ce9-b542-8ee93bfb6545.3 116
83.95
4 a78c635f-c03c-4ce9-b542-8ee93bfb6545.4 122
84.61
Source Files on build a78c635f-c03c-4ce9-b542-8ee93bfb6545