curationexperts / laevigata / ce3fcc18-e170-4b27-961e-38f0cf566a29

96%

main: 97%

Build Type

Pull #2429

circleci

Committed by mark-dce

Commit Message

[MAINTENANCE] Remove legacy data format support

**ISSUE**
At one point, the data model stored embargo flags in multiple
formats. The data has since been normalized and all ETDs are
populated with a TRUE/FALSE boolean value for each embargo flag.

An analysis of the current Solr index confirms this:
* has_model_ssim:Etd - 12,652
* abstract_embargoed_bsi:* - 12,652
* files_embargoed_bsi:* - 12,652
* toc_embargoed_bsi:* - 12,652

Further, the *_tesim values have been removed from the index (see
supporting data below)

Therefore, we no longer require the datatype fallbacks impelmented
to support the non-normalized data.

**RESOLUTION**
Simplify the SolrDocument model by removing obsolete data type spport.

**BOOLEANS**
```
/ 20240923112632
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_bsi%3A*&facet.query=files_embargoed_bsi%3A*&facet.query=toc_embargoed_bsi%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 24,
    "params": {
      "facet.query": [
        "abstract_embargoed_bsi:*",
        "files_embargoed_bsi:*",
        "toc_embargoed_bsi:*"
      ],
      "q": "has_model_ssim:Etd",
      "indent": "true",
      "q.op": "OR",
      "rows": "0",
      "facet": "true"
    }
  },
  "response": {
    "numFound": 12652,
    "start": 0,
    "maxScore": 2.7608676,
    "numFoundExact": true,
    "docs": [

    ]
  },
  "facet_counts": {
    "facet_queries": {
      "abstract_embargoed_bsi:*": 12652,
      "files_embargoed_bsi:*": 12652,
      "toc_embargoed_bsi:*": 12652
    }
  }
}
```

**_TESIM**
```
// 20240923113202
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_tesim%3A*&facet.query=files_embargoed_tesim%3A*&facet.query=toc_embargoed_tesim%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 3,
    "params": {
      "facet.query": [
        "abstract_embarg... (continued)

Pull Request Pull Request #2429: [MAINTENANCE] Remove legacy data format support

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

53 existing lines in 7 files now uncovered.

2852 of 2957 relevant lines covered (96.45%)

53.89 hits per line